Do not use string formatting LibGit2SharpException constructor when building unknown exception types

The exception constructors in GitErrorsToLibGit2SharpExceptions make use of the error category by passing it through to the NativeException(string message, GitErrorCategory category) constructor which adds ("libgit2.category", category) to Data on System.Exception.

We were calling new LibGit2SharpException(m, c), but this was resolving to the string formatting constructor on LibGit2SharpException, because it does not have a constructor that takes a category. This runs a string format, so if the errorMessage contained any curly braces, that constructor would throw an System.FormatException.

This has been changed to just use the message constructor (with no format arguments), and will drop the error code (which is always Unknown anyway).

Author: Dylan Lerch

LibGit2Sharp/Core/Ensure.cs

@@ -148,7 +148,7 @@ private static unsafe void HandleError(int result)
             Func<string, GitErrorCategory, LibGit2SharpException> exceptionBuilder;
             if (!GitErrorsToLibGit2SharpExceptions.TryGetValue((GitErrorCode)result, out exceptionBuilder))
             {
-                exceptionBuilder = (m, c) => new LibGit2SharpException(m, c);
+                exceptionBuilder = (m, c) => new LibGit2SharpException(m);
             }
 
             throw exceptionBuilder(errorMessage, errorCategory);
@@ -256,7 +256,7 @@ public static void GitObjectIsNotNull(GitObject gitObject, string identifier)
             }
 
             var messageFormat = "No valid git object identified by '{0}' exists in the repository.";
-                                        
+
             if (string.Equals("HEAD", identifier, StringComparison.Ordinal))
             {
                 throw new UnbornBranchException(messageFormat, identifier);