Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Verifier names #132

Closed
muraca opened this issue Oct 18, 2023 · 0 comments · Fixed by #139
Closed

Standardize Verifier names #132

muraca opened this issue Oct 18, 2023 · 0 comments · Fixed by #139
Assignees

Comments

@muraca
Copy link
Collaborator

muraca commented Oct 18, 2023

I noticed that SigCheck and ThresholdMultiSignature follow two fundamentally different naming standards.
I think we should either push for the long extensive name, converting the SigCheck (where I think the word "Check" is superfluous) to something like SimpleSignature, or change the second one to some ugly contraption like ThreshMultiSig, which is still well understandable but less elegant.

@JoshOrndorff said:

I slightly prefer the long extensive names. [...] If you find it worth the effort afterwards, I trust your judgement to rename things, but I'm also fine leaving it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant