[Highlights] Added text when no items are shown

Author: OffRange

app/src/main/java/de/davis/passwordmanager/ui/highlights/HighlightsFragment.java

@@ -44,7 +44,8 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
                 requireContext().getResources().getDisplayMetrics());
 
         viewModel.getElements().observe(getViewLifecycleOwner(), elements -> {
-            binding.lastUsed.removeViews(1, binding.lastUsed.getChildCount()-1);
+            binding.viewToShow.setVisibility(elements.size() > 0 ? View.GONE : View.VISIBLE);
+            binding.lastUsed.removeViews(2, binding.lastUsed.getChildCount()-2);
             elements.forEach(element -> {
                 SecureElementViewHolder viewHolder = new SecureElementViewHolder(getLayoutInflater().inflate(R.layout.item_element, null, false));
                 viewHolder.bind(element, null, this::launchElement);
@@ -55,15 +56,19 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
 
         binding.materialButtonToggleGroup.addOnButtonCheckedListener((group, checkedId, isChecked) -> viewModel.setState(group.getCheckedButtonId() == binding.lastAdded.getId()));
 
-        viewModel.getFavorites().observe(getViewLifecycleOwner(), secureElements -> secureElements.forEach(secureElement -> {
-            View fav_view = getLayoutInflater().inflate(R.layout.fav_layout, null, false);
-            ((TextView)fav_view.findViewById(R.id.title)).setText(secureElement.getTitle());
-            ((ImageView)fav_view.findViewById(R.id.image)).setImageDrawable(secureElement.getIcon(requireContext()));
+        viewModel.getFavorites().observe(getViewLifecycleOwner(), secureElements -> {
+            binding.noFavorites.setVisibility(secureElements.size() > 0 ? View.GONE : View.VISIBLE);
+            binding.favoriteContainer.removeViews(1, binding.favoriteContainer.getChildCount()-1);
+            secureElements.forEach(secureElement -> {
+                View fav_view = getLayoutInflater().inflate(R.layout.fav_layout, null, false);
+                ((TextView)fav_view.findViewById(R.id.title)).setText(secureElement.getTitle());
+                ((ImageView)fav_view.findViewById(R.id.image)).setImageDrawable(secureElement.getIcon(requireContext()));
 
-            fav_view.setOnClickListener(v -> launchElement(secureElement));
+                fav_view.setOnClickListener(v -> launchElement(secureElement));
 
-            ((ViewGroup)view.findViewById(R.id.favorite_container)).addView(fav_view);
-        }));
+                ((ViewGroup)view.findViewById(R.id.favorite_container)).addView(fav_view);
+            });
+        });
     }
 
     private void launchElement(SecureElement element){

app/src/main/res/layout/fragment_highlights.xml

@@ -21,6 +21,13 @@
                 android:layout_height="match_parent"
                 android:orientation="horizontal">
 
+                <TextView
+                    android:id="@+id/noFavorites"
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:text="@string/no_elements_to_show"
+                    android:gravity="center"
+                    android:layout_marginVertical="8dp"/>
             </LinearLayout>
         </HorizontalScrollView>
     </de.davis.passwordmanager.ui.views.InformationView>
@@ -56,6 +63,14 @@
                     android:layout_height="wrap_content"
                     android:text="@string/last_viewed"/>
             </com.google.android.material.button.MaterialButtonToggleGroup>
+
+            <TextView
+                android:id="@+id/viewToShow"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:text="@string/no_elements_to_show"
+                android:gravity="center"
+                android:layout_marginVertical="8dp"/>
         </LinearLayout>
 
     </com.google.android.material.card.MaterialCardView>