Documentation Suggestions and Component Bugs

[leddie24]

Breadcrumb

• Include variant with is-overflow
• Include max-items or breakpoint for is/isn't overflow in documentation. Component automatically adds the is-overflow class to the component if there are more than 4 items.

Button

• Clean up Best Practices list (Add bullet points or numbers to separate items)
• Add documentation on binding function to button on component instantiation. (This is demonstrated in the example code, but could be explained more explicitly)

Callout

• Clean up Best Practices list
• Component position instantiation doesn't seem to work properly (aside from "right")
• Add instructions in documentation on component parameters (constructor requires container, addTarget, and position)

Checkbox

• Add instructions in documentation on component methods (Check(), uncheck(), removeListeners())

ChoiceFieldGroup

• Add component state "is-disabled" to documentation

CommandBar

• Should contextual menu close on command selection inside CommandBar?

ContextualMenu

• Add variant ms-ContextualMenu--multiselect to documentation to show how to instantiate as a multiselect component

Dialog

• Should position be fixed rather than absolute? Component is hidden if user scrolls down on page (Issue Dialog: Change position from absolute to fixed #107, PR Change dialog position from absolute to fixed #108)
• Add component methods to documentation (open() and close())

FacePile

• PersonaCard position needs adjusting, currently covers FacePile icons

MessageBanner

• .ms-MessageBanner-expand element is never shown in the eample component
• Add component methods to documentation (showBanner())

Overlay

• Add component methods to documentation (remove(), show(), hide())

Panel

• Component animation is still bugged (this is fixed, just needs version bump in core from 3.0.0 to 3.1.0)
• Clean up component code (this._direction and this._animateOverlay) is never used

Pivot

• Suggestion: Should the button blur onclick, or remove the outline on focus?

Progress Indicator

• Add component methods to documentation (setProgressPercent(), setProgress(), setTotal(), setName(), setDescription(), cacheDOM())

Spinner

• Add component methods to documentation (Start(), stop())

Toggle

• Component has hotkey of keycode 32 (spacebar) to toggle component. Should we remove this functionality, or include this in the documentation?

[ericthompson]

Thanks, @leddie24!

[ericthompson]

Just a note - if you plan to fix one of these (please do), please file a new issue for it first so things can be tracked. Thanks!

[Linda-Editor]

Microsoft no longer supports this content and will not be responding to bugs or issues. We recommend that you use the newer version, Office UI Fabric, with React as your front-end framework. We are closing this issue; if you still need assistance with Fabric.js, visit Stack Overflow/office-ui-fabric.