bugfix(react-utilities): increments SlotRenderFunction signature to i…

…nclude children (#27377)
microsoft · Apr 3, 2023 · 60f7139 · 60f7139
1 parent 15a497f
commit 60f7139
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/change/@fluentui-react-utilities-370bb4f7-0783-4acf-bd47-07b1e38dcd19.json b/change/@fluentui-react-utilities-370bb4f7-0783-4acf-bd47-07b1e38dcd19.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "bugfix: increments SlotRenderFunction signature to include children",
+  "packageName": "@fluentui/react-utilities",
+  "email": "bernardo.sunderhus@gmail.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react-components/react-utilities/etc/react-utilities.api.md b/packages/react-components/react-utilities/etc/react-utilities.api.md
@@ -152,7 +152,7 @@ export type SlotClassNames<Slots> = {
 export type SlotPropsRecord = Record<string, UnknownSlotProps | SlotShorthandValue | null | undefined>;
 
 // @public (undocumented)
-export type SlotRenderFunction<Props> = (Component: React_2.ElementType<Props>, props: Omit<Props, 'children' | 'as'>) => React_2.ReactNode;
+export type SlotRenderFunction<Props> = (Component: React_2.ElementType<Props>, props: Omit<Props, 'as'>) => React_2.ReactNode;
 
 // @public (undocumented)
 export type Slots<S extends SlotPropsRecord> = {

diff --git a/packages/react-components/react-utilities/src/compose/getSlots.ts b/packages/react-components/react-utilities/src/compose/getSlots.ts
@@ -84,7 +84,7 @@ function getSlot<R extends SlotPropsRecord, K extends keyof R>(
     return [
       React.Fragment,
       {
-        children: render(slot, rest as Omit<R[K], 'children' | 'as'>),
+        children: render(slot, rest as Omit<R[K], 'as'>),
       } as unknown as R[K],
     ];
   }

diff --git a/packages/react-components/react-utilities/src/compose/types.ts b/packages/react-components/react-utilities/src/compose/types.ts
@@ -2,7 +2,7 @@ import * as React from 'react';
 
 export type SlotRenderFunction<Props> = (
   Component: React.ElementType<Props>,
-  props: Omit<Props, 'children' | 'as'>,
+  props: Omit<Props, 'as'>,
 ) => React.ReactNode;
 
 /**