Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid equality tests in examples, and use approx otherwise #21

Closed
Ogeon opened this issue Jan 22, 2016 · 2 comments · Fixed by #159
Closed

Avoid equality tests in examples, and use approx otherwise #21

Ogeon opened this issue Jan 22, 2016 · 2 comments · Fixed by #159
Labels
testing Improvements to (unit) testing code.

Comments

@Ogeon
Copy link
Owner

Ogeon commented Jan 22, 2016

Floating point numbers are crazy and should not be trusted. They should therefore not be compared in the examples (for aesthetic reasons) and any unit test that compares them should make use of the approx crate.

@sidred
Copy link
Contributor

sidred commented Feb 23, 2016

Should be closed by #51

@Ogeon
Copy link
Owner Author

Ogeon commented Feb 23, 2016

There are still some examples where regular equality is used (https://ogeon.github.io/docs/palette/master/palette/trait.GetHue.html for example), so this issue stays as a reminder until all of them has been changed.

@Ogeon Ogeon added the testing Improvements to (unit) testing code. label Aug 10, 2019
@bors bors bot closed this as completed in 0ac5dd2 Dec 18, 2019
@bors bors bot closed this as completed in #159 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements to (unit) testing code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants