-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derrington-Krauskopf-Lennie (DKL) color space support #376
Comments
The idea I had for LMS was to make the type aware of its own conversion matrix, but I haven't really been digging into that subject yet. I'm thinking that if there's a well known matrix from XYZ, it could be encoded as a type parameter of LMS so it remembers how to convert back. |
As far as I understand, the problem with converting from LMS to CIE 1931 XYZ is that the cone response functions (or derived colour matching functions) differ. So, you would actually need to know the precise spectral make-up of the colour in question. Also, while we're at it, there are a few other things I would really like to see:
Some of the points would require computing the conversion matrices that are currently taken from Bruce Lindbloom's website ourselves (but that should be doable at compile time without any performance implications), and functions like I realise that some of these things are quite specific to colour sciences/vision sciences/psychophysics and might not fit your vision of this crate. Let me know what you think! If you think this would be a good fit, I think I could afford putting some time into this and maybe help with maintenance a bit. I'm short on time (as always) but I will try to meet with someone from Andrew Stockman's lab next week to get a better understanding of these thing and maybe avoid some potential pitfalls. |
It's great that you bring this up, because I would surely have missed it. Let me just put on the moderator hat for a moment and ask that we keep the LMS (and DKL?) discussion in #352, so we can follow it more easily. I will respond there. The same goes for any a potential spectrum type. It would be better to have that discussion in #64. As for the rest, I'm happy to discuss possible extensions that makes Palette more useful in those subjects. I could convert this issue to a discussion thread if you would like to discuss possibilities, rather than requesting a specific feature. |
I think converting this to a discussion (or start a new one) to discuss more far-reaching questions is a good idea - let's use this one to track DKL space support! |
Sounds good! Feel free to open a discussion thread. I'll rename this issue. |
Conversion for these colour spaces depend on the spectral properties of the display, so I'm not entirely sure how to represent them in the current type system? It would either add another layer of complexity in that RGB spaces would need to be tagged with their emission spectra, or it would be a lossy conversion. Still, would be nice to be able convert them to RGB using a given conversion matrix.
I think this will need some discussion before persuing this, but see: #352
The text was updated successfully, but these errors were encountered: