Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to identify positive samples and negative samples? #9

Open
MAxx8371 opened this issue Aug 26, 2023 · 1 comment
Open

How to identify positive samples and negative samples? #9

MAxx8371 opened this issue Aug 26, 2023 · 1 comment

Comments

@MAxx8371
Copy link

MAxx8371 commented Aug 26, 2023

In the paper, it mentions that the score is defined as follow. Is that calculated by summing the logprob of each token of the ground true y conditioned on (e,x)? If that were right, the score would not be between 0 and 1 as shown in the pic. In that case, what is the threshold used for identifying pos&neg samples? Appreciate it!
截屏2023-08-26 11 00 49
截屏2023-08-26 11 05 38

@OhadRubin
Copy link
Owner

OhadRubin commented Aug 26, 2023

In the paper, it mentions that the score is defined as follow. Is that calculated by summing the logprob of each token of the ground true y conditioned on (e,x)?

Yes, you are correct.

If that were right, the score would not be between 0 and 1 as shown in the pic. I

Yes. I found it to be more intuitive to explain with probability instead of logprobs.... It means the same thing.

In that case, what is the threshold used for identifying pos&neg samples?

We just take the top-5 as positive and the bottom-5 as negative.
Since all the candidates are from a BM25, the bottom-5 are good negatives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants