Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Launcher/All): Split dockerization for different environments #2

Open
memarin opened this issue Jan 16, 2025 · 0 comments
Open

(Launcher/All): Split dockerization for different environments #2

memarin opened this issue Jan 16, 2025 · 0 comments

Comments

@memarin
Copy link

memarin commented Jan 16, 2025

Since the Dockerfiles have distinct configurations and requirements between launcher and deployment environments, we will implement separate Docker configurations for each environment. This separation will help maintain cleaner version control by preventing merge conflicts that often arise when different teams work on environment-specific Docker settings. By maintaining dedicated configurations for each environment, we can ensure better organization of our Docker setup and allow for independent evolution of launcher and deployment specifications without interference.

cont.

we also need to clear up the env var confusion between prod vars and local vars. we can either split .env.example into .env.prod.example & .env.local.example , OR we keep the same .env.example and just add clear details to the viewer, i.e.

### PROD ###
a=...
b=...
c=...

### LOCAL ###
a=...
b=...
c=...
d=...
e=...

Can we remove the re-declaring of a, b & c and add a comment saying “local needs all above (prod) vars, along with the following..."

Currently it is hard for devops to look at the .env.examples to know which vars are actually necessary for deployments, and which ones are only necessary for running repos locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant