New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Contracts) Consolidate events 2: move remaining events and update fields #182

Open

memarin opened this issue Jan 16, 2025 · 0 comments

Assignees

memarin commented Jan 16, 2025

Sub Task 2:

🏗️ All write functions need their events moved to the vault. This goes for the above functions, as well as:

start_auction (AuctionStarted)
end_auction (AuctionEnded)
settle_round (OptionRoundSettled)

🏗️ Additionally, [this function call]also needs its event moved inside the vault (PricingDataSet)

🏗️ Since we are moving the events inside the vault, we will need to emit the round ID and round address in the events (all other fields will remain).

memarin assigned eugenPtr

memarin transferred this issue from OilerNetwork/pitchlake-ui-new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment