Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - pagination is not a function #395

Open
onursonmez opened this issue Apr 1, 2024 · 3 comments
Open

🐛 [BUG] - pagination is not a function #395

onursonmez opened this issue Apr 1, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@onursonmez
Copy link

onursonmez commented Apr 1, 2024

Description

I installed the Falcon theme. 1 of my products has comments from more than one page. Paging is not working. I get the following error:

Uncaught TypeError: $(...).pagination is not a function at Object.success (bottom-7a2b0d118.js?v=5ef059938ba799aaa845e1c2e8a762bd:631:287) at c (bottom-7a2b0d118.js?v=5ef059938ba799aaa845e1c2e8a762bd:37:28579) at Object.fireWith [as resolveWith] (bottom-7a2b0d118.js?v=5ef059938ba799aaa845e1c2e8a762bd:37:29327) at T (bottom-7a2b0d118.js?v=5ef059938ba799aaa845e1c2e8a762bd:37:80208) at XMLHttpRequest.<anonymous> (bottom-7a2b0d118.js?v=5ef059938ba799aaa845e1c2e8a762bd:37:82676)

I see that there is a pagination function in https://falcon-theme.dev/themes/falcon/assets/cache/bottom-bb9dfd2.js?v=c81e728d9d4c2f636f067f89cc14862c. This pagination is the same as the code in https://gist.github.com/albertotain/3bdf6fb92ba73f695df81f4218213d4f. However, this does not appear in my source code. I can't understand why.

Falcon-theme@3.1.2 build
webpack --progress --mode=production --env stats=errors-only

I think my problem is that the "yarn build" is not completed. Because I get an error like this:

95% emitting emit(node:36283) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated. BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation. Do changes to assets earlier, e. g. in Compilation.hooks.processAssets. Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*. (Usenode --trace-deprecation ...to show where the warning was created)

Node.js version

v18.19.1

php version

v8.0

OS and it's version

Ubuntu

Browsers

Chrome

Required module/theme

theme

Reproduction steps

1. Go to _dev folder
2. Run yarn build
3. Go to https://fegge.com/colorful-nail-polish-1823.html
4. See error

Logs

No response

@onursonmez onursonmez added the bug Something isn't working label Apr 1, 2024
@onursonmez
Copy link
Author

i run npm run add-entry command and then add https://gist.githubusercontent.com/albertotain/3bdf6fb92ba73f695df81f4218213d4f/raw/f2dba6151c5976f362d984a732a37ae792c77c2d/simplePagination.js to new entry. comment pagination worked.

@maofree
Copy link

maofree commented Apr 14, 2024

Hi
I've the same error

1

I've fixed this problem using a differente method, avoiding using "pagination" but the form code in javascript, which also seems better to me for ajax calls

@Oksydan this folder must be placed in the modules folder of the theme in use
productcomments.zip

bye

@Oksydan
Copy link
Owner

Oksydan commented Apr 16, 2024

Hi,
I am aware of this problem. In recent version productcomments get rid of jQuery plugin. It's using different library for pagination. On develop branch it's has been fixed and it will be available in version 4 (we are using our custom pagination library).
Unfortunately I have been a bit too busy lately and have not been able to work on Falcon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants