Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit of 1 tag per page #5

Closed
stijnswinnen opened this issue Feb 17, 2019 · 8 comments
Closed

Limit of 1 tag per page #5

stijnswinnen opened this issue Feb 17, 2019 · 8 comments
Assignees
Labels
bug Something isn't working replicated

Comments

@stijnswinnen
Copy link

It seems there's a limit of 1 tag per page. Is this correct and can this be changed?

@OleVik
Copy link
Owner

OleVik commented Feb 17, 2019

The amount of tags applied per page is only limited by the amount of tags and their length, as limited by the browser's maximum GET query. For example, the URL http://writing.local/projects/tag:X2+-+Cohesive+actors,C1+-+Confounder applies the tags X2 - Cohesive actors and C1 - Confounder. The same applies to all other taxonomies used by the theme.

Are you having issues applying more than 1 tag?

@stijnswinnen
Copy link
Author

Thank you for the fast reply. After investigating the issue more, it might indeed be another reason related to the admin panel.
What I notice I do can add more than 1 tag when working in expert mode. The issue is in Normal mode only 1 tag is displayed. So when doing an update of an existing page in Normal mode, the number of tags gets reduced to 1.

@OleVik
Copy link
Owner

OleVik commented Feb 17, 2019

The issue is probably upstream, with how Admin handles the selectize-field. It seems this was resolved with 1461, through a related commit.

Could you try editing post.yaml in the theme's /blueprints, and adding in merge_items: true anywhere in the selectize-field declaration?

@stijnswinnen
Copy link
Author

At first sight it doesn't seem to change anything. Changed the setting, cleared cache and signed in again,
Following the same workflow. the issue remains. First save in expert mode to save several tags. switched to Normal mode and saved again to result in loos of all but the first tag.

saved in Expert mode, several tags
screen shot 2019-02-17 at 22 33 27
Saved in Normal mode, only 1 tag,
screen shot 2019-02-17 at 22 33 44

@OleVik
Copy link
Owner

OleVik commented Feb 17, 2019

I'll run some tests and see if I can replicate the issue.

@OleVik OleVik self-assigned this Feb 17, 2019
@OleVik OleVik added bug Something isn't working replicated labels Feb 17, 2019
@OleVik
Copy link
Owner

OleVik commented Feb 17, 2019

The issue is indeed upstream on the Admin-side, the tags are loaded initially but cleared out when the JS initiates. That is to say, you can still use multiple tags from the Admin, and save them, but once the page reloads they are replaced with just 1. If you do not save again, the original selected tags are still kept in the Markdown-file, however - unless you save again with just the 1.

@OleVik
Copy link
Owner

OleVik commented Feb 17, 2019

This is fixed with Grav v1.6.0-rc.2 and Admin v1.9.0-rc.2, as the fix with merge_items was added in Admin v1.9.0-beta.7. So you'll either have to make due until they both become stable, or upgrade to the testing releases.

@OleVik OleVik closed this as completed Feb 17, 2019
@stijnswinnen
Copy link
Author

Thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replicated
Projects
None yet
Development

No branches or pull requests

2 participants