feat: allow optional commas in arrays (#87)

OmarTawfik · May 1, 2019 · c0346ad · c0346ad
1 parent 5e0fff9
commit c0346ad
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/docs/grammar.md b/docs/grammar.md
@@ -64,7 +64,7 @@ key : ON_KEYWORD
 value : STRING_LITERAL | string_array | env_variables ;
 
 string_array : LEFT_SQUARE_BRACKET
-               ((STRING_LITERAL COMMA)* STRING_LITERAL COMMA?)?
+               (STRING_LITERAL COMMA?)*
                RIGHT_SQUARE_BRACKET ;
 
 env_variables : LEFT_CURLY_BRACKET (env_variable)* RIGHT_CURLY_BRACKET ;

diff --git a/gulpfile.ts b/gulpfile.ts
@@ -8,6 +8,7 @@ import { LinterTasks } from "./scripts/gulp-linter";
 import { VSCodeTasks } from "./scripts/gulp-vscode";
 
 // TODO: replace all module-like files with classes
+// TODO: Use discriminated unions instead of kinds and remove all casts
 
 // Called by debugger before launching
 gulp.task("update-vscode", gulp.series([BuildTasks.compile, VSCodeTasks.copyFiles, VSCodeTasks.generatePackageJson]));

diff --git a/test/parsing.spec.ts b/test/parsing.spec.ts
@@ -120,4 +120,26 @@ ERROR: A token of kind ',' was not expected here.
 "
 `);
   });
+
+  it("does not report errors on missing commas", () => {
+    expectDiagnostics(`
+action "a" {
+  uses = "./ci"
+}
+action "b" {
+  uses = "./ci"
+}
+action "c" {
+  uses = "./ci"
+}
+workflow "x" {
+  on = "fork"
+  resolves = [
+     "a",
+     "b"
+     "c",
+  ]
+}
+`).toMatchInlineSnapshot(`""`);
+  });
 });