Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive plex username causing SSO from orgranizr to fail #3064

Closed
riemers opened this issue Jul 13, 2019 · 9 comments
Closed

Case sensitive plex username causing SSO from orgranizr to fail #3064

riemers opened this issue Jul 13, 2019 · 9 comments
Labels

Comments

@riemers
Copy link

riemers commented Jul 13, 2019

Describe the bug
If the Organizr user logs in as "username" and it tries to go to Ombi by means of SSO it will fail if the user in the Plex import user list of Ombi is called "Username" the list is case sensitive.

Most of the users don't even know it has a uppercase first letter since lowercase works too on plex logins.

Expected behavior
To be able to login with lowercase username too. (should not be case sensitive)

Ombi Version (please complete the following information):

  • Version 3.0.4659 (master)

Additional context
Something similar in the past #882 (might not be the right context, but looks same back then) could not find anything else matching that. Did search for it in the code, but lot has changed since then :)

@ombi-bot
Copy link
Contributor

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Have you looked at the wiki yet? https://github.com/tidusjar/ombi/wiki/
Before posting make sure you also read our FAQ.
Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Thanks!
Ombi Bot.

@tidusjar
Copy link
Member

tidusjar commented Aug 1, 2019

Any idea what API Org is using to login?

@riemers
Copy link
Author

riemers commented Aug 1, 2019

I don't really, but the settings i have placed in it are just the "http://ombi:3579" and then the token.

As described here https://docs.organizr.app/books/setup-features/page/sso#bkmrk-ombi. It uses an auth token too from what i can tell. If that fails to map it won't continue. (assuming this is part of the info your looking for) otherwise point me where to look and i will see if i can find the information.

@tidusjar
Copy link
Member

tidusjar commented Aug 1, 2019

Are you sure this is the behaviour you are seeing? Since I don't understand how casing matters.

Can you login directly on Ombi with a different case username?

@riemers
Copy link
Author

riemers commented Aug 1, 2019

I think i narrowed it down a bit. The first account i create on Organizr was with different usercase then the one that got imported on Ombi. Since i imported all my users in Organizr it skipped my account because it was already there not fixing the one letter with different casing. I fixed it manually for my user and that seems to be ok now. Checked all other users and they have the same case as the ones in Organizer now.

But i would presume casing should not matter when it comes to usernames. So if i now change my username in Ombi to "riemers" instead of "Riemers" as example it would fail to log me in automaticly. (since the cookie auth as described in the url above will have the "Riemers" with uppercase in it) and that is what most likely made it fail.

@tidusjar
Copy link
Member

tidusjar commented Aug 1, 2019

So what seems to happen is that Org calls out to the Ombi API with the username and password and Ombi returns a JWT Token. Org then pushes that into a cookie.
When org goes to the ombi cookie page we read out the JWT token from the cookie and then you are authenticated.

I am struggling to see how casing on usernames matter here. 😢

@riemers
Copy link
Author

riemers commented Aug 1, 2019

I am no expert, i only know that when i changed my username to match the one i have in organizr it worked fine. We could also just say, it is a one off 'issue' and by changing the name it is fine now and be done with it. I just thought it is good to report these kinds of things :)

@stale
Copy link

stale bot commented Sep 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 30, 2019
@riemers
Copy link
Author

riemers commented Sep 30, 2019

I think we can call this as , it is solved. A weird one and lets move on..

@riemers riemers closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants