Ombi fails to set episode statuses via SiCKRAGE if it fails on a single episode status change

[echel0n]

Describe the bug
I've recently resolved all API call issues for our legacy API v1 in SR v10.0.60, Ombi does now work correctly, however, I have noticed that if Ombi fails to set a episode status it will forgo even attempting the next season.

For example, the show "Robinson" season 8 in SR has all its episodes unaired, SR will not allow episode status changes to unaired episodes, so it kicks back a failure on the API call, this causes Ombi to not even attempt setting episode statuses for season 9 or greater.

I propose the logic be changed for Ombi so that it tries all seasons and episodes regardless of if it fails setting episode status on a single episode, its far better then just giving up on other episodes that very well can have their status changed.

To Reproduce
Steps to reproduce the behavior:

1. Add show "Robinson"
2. Check SiCKRAGE and see "Robinson" episode status set to ignored

Expected behavior
Ombi to set episode status regardless if it encounters an error

Screenshots
NA

Logs (Logs directory where Ombi is located)
NA

Desktop (please complete the following information):

• OS: Windows

Ombi Version (please complete the following information):

• Version 4.16.12
• Media Server: Plex
• Database Type: SQLite
• SiCKRAGE v10.0.60

Additional context
NA

[github-actions]

Hi!

Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.

Have you looked at the wiki yet? https://docs.ombi.app/

Before posting make sure you also read our FAQ.

Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.

If we need more information or there is some progress we tag the issue or update the tag and keep you updated.

Thanks!

Ombi Bot.

[echel0n]

I should also note that when attempting to change a episode status via SR API, if it fails in SR to change that status, it adds that response to an array of objects that is returned back in the data path of the response, looking over the models for SR in Ombi, it would not seem that Ombi expects the data path to be an array, now my c# is a little rusty so I could be wrong about that as well.

[echel0n]

I've created the following pull request to correct this #4648

[echel0n]

I've also pushed a new release that will always return an array of objects when changing episode statuses, regardless of if the episode status change was successful or not, previous versions did not return an array of objects for successful episode status changes, only for changes that failed.

[echel0n]

I see that my merge request has been merged, thanks, I'll close this ticket out now.