Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the requests page, needs to support 700+ requests #481

Closed
SpartacusIam opened this issue Aug 19, 2016 · 13 comments
Closed

Rework the requests page, needs to support 700+ requests #481

SpartacusIam opened this issue Aug 19, 2016 · 13 comments

Comments

@SpartacusIam
Copy link

SpartacusIam commented Aug 19, 2016

If this is a bug report please make sure you have filled the following in:
(If it's not a bug and a feature request then just remove the below)

Plex Requests.Net Version:

1.9

Operating System:

Docker on Ubuntu 16.04

Mono Version:

Applicable Logs (from /logs/ directory or the Admin page):

Logs go here (Please make sure you remove any personal information from the logs)

Reproduction Steps:

When I search for and request a movie I see the movie show up in CouchPotato. Howerver when I click on the Requests page it's blank. It's reading something because as you can see the "Sorry, we didn't find any results" message is gone. Then, if I click "Delete Movies" and try to search for the same movie again it shows it's been requested and I can't add it. Logs are empty even with log level set to Trace.

@tidusjar
Copy link
Member

Anything in the browsers console? F12? There should be an error in red, if you click on it and post the response?

On 19 Aug 2016, at 10:55 pm, jimphreak notifications@github.com wrote:

If this is a bug report please make sure you have filled the following in:
(If it's not a bug and a feature request then just remove the below)

Plex Requests.Net Version:

1.9

Operating System:

Docker on Ubuntu 16.04

Mono Version:

Applicable Logs (from /logs/ directory or the Admin page):

Logs go here (Please make sure you remove any personal information from the logs)
Reproduction Steps:

When I search for and request a movie I see the movie show up in CouchPotato. Howerver when I click on the Requests page it's blank. It's reading something because as you can see the "Sorry, we didn't find any results" message is gone. And if I search for a movie I've already added it tells me it's been requested even though the Requests page is blank. Logs are empty even with log level set to Trace.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@SpartacusIam
Copy link
Author

SpartacusIam commented Aug 19, 2016

I see no errors when I hit F12. I've tried in both Chrome and IE11.

P.S. I have deleted my database and started from scratch and the problem exists.

@tidusjar
Copy link
Member

Strange, I cannot reproduce this. Are we able to do some sort of remote desktop session so you can show me via teamviewer or something?

@zenjabba
Copy link

I'm also having the same problem, but it simply seems it taking so long to load the list.

Happy to share my database so you can look at it.

@tidusjar
Copy link
Member

@zenjabba If you could that would be great, can you just change the admin password.

jamierees@outlook.com

@zenjabba
Copy link

zenjabba commented Aug 21, 2016

password: password

@tidusjar
Copy link
Member

Thanks, I removed the link just incase you may have any personal info in your logs

@zenjabba
Copy link

Understood.

@tidusjar
Copy link
Member

tidusjar commented Aug 21, 2016

Wow, I know your problem @zenjabba there are too many movies to load at one time and the UI can't cope. Looks like I'm going to have to add some sort of paging

@jimphreak Is your couchpotato set up correctly?

@zenjabba
Copy link

@tidusjar I'm a good test site for large data testing. Let me know when you're needing a beta tester

@tidusjar
Copy link
Member

Thanks @zenjabba

Yeah you have over 700 movie requests, the UI was never meant to hold that much data!

I'm going to have to redesign the requests UI.

Server > Client = milliseconds.

Client rendering is where the time is being spend, I am using the template framework handlebars to render each movie request and it's not optimal for 700!

I'm thinking about moving the ordering/filtering to the server and introducing something like paging or page virtualization.

It's no easy task though...

For now @zenjabba I can delete all your approved and available requests so you can see the page?

@zenjabba
Copy link

zenjabba commented Aug 21, 2016

If I leave it long enough, it comes good. I'll wait till you update the code.

We generally get around 100 new movies a week, so it's a very busy plex server farm.

On 21 Aug 2016, at 2:09 PM, Jamie notifications@github.com wrote:

Thanks @zenjabba

Yeah you have over 700 movie requests, the UI was never meant to hold that much data!

I'm going to have to redesign the requests UI.

Server > Client = milliseconds.

Client rendering is where the time is being spend, I am using the template framework handlebars to render each movie request and it's not optimal for 700!

I'm thinking about moving the ordering/filtering to the server and introducing something like paging or page virtualization.

It's no easy task though...

For now @zenjabba I can delete all your approved and available requests so you can see the page?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@tidusjar
Copy link
Member

OK

@tidusjar tidusjar changed the title Requests Page Shows No Requested Movies Rework the requests page, needs to support 700+ requests Aug 21, 2016
@Magikarplvl4 Magikarplvl4 added this to the Release v1.10.0 milestone Nov 2, 2016
@Magikarplvl4 Magikarplvl4 modified the milestones: Release v2.0, V2.1 release Jan 4, 2017
@Magikarplvl4 Magikarplvl4 modified the milestones: V2.X release pool , 2.3 Jan 12, 2017
@Magikarplvl4 Magikarplvl4 removed this from the Release v2.3 milestone Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants