Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gem rounding error #146

Open
markliu06 opened this issue Feb 26, 2021 · 2 comments
Open

gem rounding error #146

markliu06 opened this issue Feb 26, 2021 · 2 comments

Comments

@markliu06
Copy link

markliu06 commented Feb 26, 2021

Can't remember which gem has this error in 3.12

But try to re-export data for 3.13, still has this error for "Arcane Surge Support"

It should be "Arcane Surge grants 0.01% of Mana Regenerated per second"

instead of 0% (Anomalous Arcane Surge Support)

@markliu06 markliu06 changed the title gem alt quality rounding error gem rounding error Feb 27, 2021
@markliu06
Copy link
Author

markliu06 commented Feb 27, 2021

Ok, for blast rain. The gem text became

Deals (30-35.599999999999994)% of Base Attack Damage

(Should round to nearest integer for this case https://www.pathofexile.com/forum/view-thread/3009537 ; all base damage for all level are wrong too)

@markliu06
Copy link
Author

markliu06 commented Feb 27, 2021

It seems the rounding error appear in Burning Arrow too (or may be all gem with Deals #% of Base Attack Damage?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant