Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace model specific score functions with generic ones? #76

Closed
RemyLau opened this issue Dec 13, 2022 · 2 comments
Closed

Replace model specific score functions with generic ones? #76

RemyLau opened this issue Dec 13, 2022 · 2 comments

Comments

@RemyLau
Copy link
Collaborator

RemyLau commented Dec 13, 2022

Currently, each model comes with a .score function for evaluating the model performance. Most of them do the same thing, e.g., compute model accuracy for cell-type annotation tasks. Why not just have one generic function that calculates the accuracy (and similarly for other tasks)?
@RemyLau
Copy link
Collaborator Author

RemyLau commented Dec 15, 2022

  • Follow scklearn convention: score takes feature and label as input and spits out score, with an option to select the type of score.
  • Refactor models to make generic score function

@RemyLau
Copy link
Collaborator Author

RemyLau commented Jan 27, 2023

Closing as it is being tracked in #143

@RemyLau RemyLau closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RemyLau