Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink how feature checks are performed #107

Closed
Omikhleia opened this issue Jan 28, 2024 · 1 comment · Fixed by #112
Closed

Rethink how feature checks are performed #107

Omikhleia opened this issue Jan 28, 2024 · 1 comment · Fixed by #112
Assignees
Labels
breaking Something is heavily broken with no workaround bug Something isn't working
Milestone

Comments

@Omikhleia
Copy link
Owner

Omikhleia commented Jan 28, 2024

You can't make an omelette without breaking eggs

After struggling with making silex.sile v0.4 less aggressive and not replace SILE's internals globally... I realize that markdown.sile actually enforces the replacements indirectly...

This is due to the feature check it does, loading the resilient class (which enforces all of silex):

local ok, ResilientBase = pcall(require, 'classes.resilient.base')
self.isResilient = ok and self.class:is_a(ResilientBase)

So even processing a document using the bare "book" ends up loading the silex replacements at some point (and possibly in the course of a document processing, which then causes havoc)

We'd possibly need to do those checks differently, there's some wrong inversion of logic.

@Omikhleia Omikhleia added bug Something isn't working breaking Something is heavily broken with no workaround labels Jan 28, 2024
@Omikhleia
Copy link
Owner Author

Workaround in v1.5.2 so it works with silex v0.4, but general issue kept open -- it's perhaps time to trying preparing for SILE 0.15 and reconsider options.

@Omikhleia Omikhleia added this to the 1.6.0 milestone Feb 3, 2024
@Omikhleia Omikhleia self-assigned this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Something is heavily broken with no workaround bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant