Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differentiate between dependencies and dev-dependencies for the sake of size #21

Open
jrieken opened this issue Aug 26, 2015 · 7 comments
Assignees

Comments

@jrieken
Copy link
Contributor

jrieken commented Aug 26, 2015

Installing omnisharp-client consumes 96MB on disk while OmniSharp itself just the half (46MB). tsd and typescript, which seem like dev dependencies, sum up to 26MB. So some low hanging fruit here...

@jrieken
Copy link
Contributor Author

jrieken commented Aug 26, 2015

btw - I'd like to sign up for this.

@jrieken
Copy link
Contributor Author

jrieken commented Aug 26, 2015

Also it seems that RX can be slimmer. I see all files in dist/ being foo.[js|map|min.js]...

@david-driscoll
Copy link
Member

Sounds good to me!

I do know that as part of the install process we run the typescript task through the post-install and pre-publish commands for npm. So we might have to fiddle with the build to get the proper JS output stashed to npm, without requiring the .ts files to be published (or publish them, but don't try to regenerate them).

Depend on what happens above we might also need to generate the declarations for local developers so they get the type information (today atom just references the ts files through the node_modules directory).

PS: Does this mean VSCode might be evaluating using the same dep as atom? 😀

If you want to try and pair sometime to figure what we need to do out, I can make time for sure.

@david-driscoll
Copy link
Member

Rx also has https://github.com/Reactive-Extensions/RxJS-Modular but it hasn't been updated in a few months, maybe @mattpodwysocki might have some input.

Worst case on the Rx front we could take a local dependency on it, and just copy the raw file from github into the release based on whatever release we're looking at, and then remove it as a direct dependency.

@david-driscoll
Copy link
Member

oh there's also https://github.com/Reactive-Extensions/RxJS-CLI maybe that could be useful.

@david-driscoll
Copy link
Member

I've got my changes @ https://github.com/OmniSharp/omnisharp-node-client/tree/diet-publish

@jrieken let me know if you want me to push them onto diet and we can merge it.

@jrieken
Copy link
Contributor Author

jrieken commented Sep 2, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants