Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide options to control MSBuild discovery and selection #1186

Closed
DustinCampbell opened this issue May 11, 2018 · 6 comments
Closed

Provide options to control MSBuild discovery and selection #1186

DustinCampbell opened this issue May 11, 2018 · 6 comments
Assignees
Labels

Comments

@DustinCampbell
Copy link
Contributor

No description provided.

@Pilchie
Copy link
Contributor

Pilchie commented Mar 21, 2019

@rchande / @akshita31 Note - I think this will be important for .NET Core 3, given that the VS 2017 MSBuild is marked as incompatible with .NET Core 3. For me, with both VS 2017 and 2019 installed, Omnisharp always picks the 2017 instance, even if I start from a 2019 command prompt :(

@rainersigwald
Copy link
Contributor

The command prompt problem should be fixed by #1347.

Tactically, it might also be good to do some sorting in VisualStudioInstanceProvider. Maybe just by version descending, though it might also be nice to work in prerelease/not somehow--but that probably just takes you back to configuration. On my machine I'd want prerelease highest always, but that's because I work on VS and any released version of VS I have installed is an emergency backup/repro environment.

@Pilchie
Copy link
Contributor

Pilchie commented Mar 21, 2019

And #1347 should be in the next release already.

@peter-vanpoucke
Copy link

Any progress on this? Because it seems only this workaround can fix this...

@JohnGalt1717
Copy link

Same here. It's insisting on selecting VS.net 2019 Preview msbuild and then doesn't suggest anything as a result.

@filipw
Copy link
Member

filipw commented Aug 20, 2020

This was implemented in #1545 (comment)

@filipw filipw closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants