Build checkouted version fail

[JulioJu]

It seems it's not possible to compile an old version of omnisharp-rosly without make a new branch.

For instance:

git checkout 1dd917436661f250c4aa6305a4ec442262d76187
# without forget https://github.com/OmniSharp/omnisharp-roslyn/issues/1202#issuecomment-421543905
./build.sh --target Quick --verbosity Verbose --use-global-dotnet-sdk

doesn't work !

but the following works

git checkout 1dd917436661f250c4aa6305a4ec442262d76187
# without forget https://github.com/OmniSharp/omnisharp-roslyn/issues/1202#issuecomment-421543905
git checkout -b 327
./build.sh --target Quick --verbosity Verbose --use-global-dotnet-sdk

I've had this issue when I've tried to bisect to resolve OmniSharp/omnisharp-vim#427 with @nickspoons

Anybody could confirm ? If it's confirmed, maybe this tip could be added in the README.md ?

[rchande]

@JulioJu Can you share the error?

[JulioJu]

hi @rchande

$ dotnet --version
2.1.301

$ mono --version
Mono JIT compiler version 5.16.0 (makepkg/6e48ad4f7b1 Mon Oct 15 22:56:48 CEST 2018)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
        TLS:           __thread
        SIGSEGV:       altstack
        Notifications: epoll
        Architecture:  amd64
        Disabled:      none
        Misc:          softdebug
        Interpreter:   yes
        LLVM:          supported, not enabled.
        GC:            sgen (concurrent by default)

Without forget #1202 (comment) (I'm on Arch Linux, I should modify two files).

$ git checkout  0496b7e9 # release 1.32.8, but i've tested with lot of releases.

$ ./build.sh --target Quick --verbosity Verbose --use-global-dotnet-sdk
Feeds used:
  /home/julioprayer/.nuget/packages/
  https://api.nuget.org/v3/index.json
  https://dotnet.myget.org/F/dotnet-core/api/v3/index.json

All packages listed in /media/data/home/omnisharp-roslyn/tools/packages.config are already installed.
Analyzing build script...
Processing build script...
Installing tools...
Installing addins...
Compiling build script...
Error: One or more errors occurred.
        GitVersion: Process returned an error (exit code 1).

If I create a new branch with

$ git checkout -b 328

All work well.

@rchande what do you think about that ? It it confirmed ? At least on MS Windows ?

[rchande]

@JulioJu Yes, this is a known limitation with GitVersion (it crashes if you check out a commit with no tag/branch) and also happens on windows. I don't think we plan to fix this specifically, but it may go away if we upgrade to a later instance of GitVersion. cc @david-driscoll

[JulioJu]

@rchande thanks for your answer :-)

[filipw]

We moved to latest GitVersion which resolved the problem.