Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C# 10] Code lens doesn't work with file scoped namespaces #2225

Closed
vchirikov opened this issue Sep 2, 2021 · 1 comment · Fixed by #2226
Closed

[C# 10] Code lens doesn't work with file scoped namespaces #2225

vchirikov opened this issue Sep 2, 2021 · 1 comment · Fixed by #2226

Comments

@vchirikov
Copy link

csharplang/file-scoped-namespaces.md

Omnisharp: 1.37.15-beta.34
omnisharp-vscode: v1.23.15

Expected behavior

image

Actual behavior

image
@JoeRobich
Copy link
Member

The fix would be to update the CodeStructureService to handle the new BaseNamespaceDeclarationSyntax instead of NamespaceDeclarationSyntax (see https://github.com/OmniSharp/omnisharp-roslyn/blob/master/src/OmniSharp.Roslyn.CSharp/Services/Structure/CodeStructureService.cs#L88). Moving to OmniSharp-Roslyn.

@JoeRobich JoeRobich transferred this issue from dotnet/vscode-csharp Sep 2, 2021
@JoeRobich JoeRobich mentioned this issue Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CodeStructureService with FileScoped Namespace support JoeRobich/omnisharp-roslyn
2 participants
@JoeRobich @vchirikov