Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliable way to lock up vscode #1088

Closed
NinoFloris opened this issue Dec 25, 2016 · 2 comments
Closed

Reliable way to lock up vscode #1088

NinoFloris opened this issue Dec 25, 2016 · 2 comments

Comments

@NinoFloris
Copy link

NinoFloris commented Dec 25, 2016

Environment data

dotnet --info output:
.NET Command Line Tools (1.0.0-preview2-1-003177)

Product Information:
Version: 1.0.0-preview2-1-003177
Commit SHA-1 hash: a2df9c2576

Runtime Environment:
OS Name: Mac OS X
OS Version: 10.11
OS Platform: Darwin
RID: osx.10.11-x64
VS Code version:
1.8.1
C# Extension version:
1.6.1

Steps to reproduce

Set file to C# and paste this in, next try to add any generic type to the int on _totalLockup.

using System;
using System.Collections.Generic;

public class Bizarre 
{
    // Typing X< (say List<) before x (int here) works fine when TKey is not RuntimeTypeHandle
    private Dictionary<Type, int> _worksFine;

    // With RuntimeTypeHandle this fully locks up VSCode until it shows the 'window unresponsive' dialog
    private Dictionary<RuntimeTypeHandle, int> _totalLockup;
}

See tweet for repro https://twitter.com/NinoFloris/status/812838424545783808

@DustinCampbell
Copy link
Member

This looks like a duplicate of #1086.

@DustinCampbell
Copy link
Member

OK. All of my analysis is in #1086. I'm closing this as a dupe of this issue. However, thanks very much for your excellent repro. I've pushed a new release (1.6.2) that should address this problem. It's not a perfect solution, but it won't hang any longer. If you're interested in seeing what happened, check out issue #1086 and the PR I merged to workaround it: #1089.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants