Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly Metadata View did not Support #165

Closed
ChongWangUBI opened this issue Apr 10, 2016 · 4 comments
Closed

Assembly Metadata View did not Support #165

ChongWangUBI opened this issue Apr 10, 2016 · 4 comments
Labels
Feature Request Resolved-Fixed
Milestone
1.4

Comments

@ChongWangUBI
Copy link

Does vscode support Metadata View Support like atom ?
like omnisharp-atom/lib/server/metadata-editor.ts
@ChongWangUBI ChongWangUBI changed the title Assembly Metadata View did not Support? Assembly Metadata View did not Support Apr 10, 2016
@ChongWangUBI
Copy link
Author

VSCode Version 0.10.11 (0.10.11)
OS: Mac OSX

by Add a WantMetaData:true in the gotodefine request [typeConvertion.js]
I implement a simple version:
test code in CSharpDefinitionProvider like follow:
test

@Pilchie
Copy link
Member

Pilchie commented Apr 11, 2016

Definitely need this.

@DustinCampbell DustinCampbell mentioned this issue May 10, 2016
Closed
@DustinCampbell DustinCampbell added this to the future milestone Jul 21, 2016
@DustinCampbell DustinCampbell mentioned this issue Aug 15, 2016
Closed
@ivanz
Copy link
Contributor

ivanz commented Aug 15, 2016

Claiming this one. Have some work in progress already. Will finish off and create a pull request in the next couple of days.

@ivanz
Copy link
Contributor

ivanz commented Aug 16, 2016 •
edited
Loading

Here is what I managed to do (thanks to ChongWangUBI for the screenshot which gave me a lot of the info that I needed).

@DustinCampbell Are we happy with this UI behavior, etc?

2016-08-16_15-23-19

ivanz added a commit to ivanz/omnisharp-vscode that referenced this issue Aug 16, 2016
@ivanz
Implemented support for "Go to definition" to "3rd party" assemblies …
95002cf 
…using type metadata. Fixes dotnet#165
@ivanz ivanz mentioned this issue Aug 16, 2016
Closed
ivanz added a commit to ivanz/omnisharp-vscode that referenced this issue Aug 16, 2016
@ivanz
Implemented support for "Go to definition" to "3rd party" assemblies …
e1f243a 
…using type metadata. Fixes dotnet#165
ivanz pushed a commit to ivanz/omnisharp-vscode that referenced this issue Aug 16, 2016
@chuckries @ivanz
Implemented support for "Go to definition" to "3rd party" assemblies …
5ccbe61 
…using type metadata. Fixes dotnet#165
ivanz added a commit to ivanz/omnisharp-vscode that referenced this issue Aug 16, 2016
@ivanz
Implemented support for "Go to definition" to "3rd party" assemblies …
44b4b15 
…using type metadata. Fixes dotnet#165
This was referenced Aug 16, 2016
Closed
Merged
@DustinCampbell DustinCampbell modified the milestones: 1.4, future Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Resolved-Fixed
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
4 participants
@ivanz @DustinCampbell @Pilchie @ChongWangUBI