Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all providers support #3440

Merged
merged 24 commits into from
Aug 12, 2020
Merged

Conversation

savpek
Copy link
Contributor

@savpek savpek commented Dec 5, 2019

Vscode implementation for OmniSharp/omnisharp-roslyn#1581

Todo:

  • Tests (once omnisharp-roslyn side is available for CI builds)
  • Refactor copy-paste code from service as common base or something.

Supports:

  • Fix one category (by ID) to fix in document, project and solution scope.
  • Fix all autofixable issues in document scope.
  • Fix all issues in current document on save.

Document scope
fix_onebyone_document

Project scope
fix_one_by_one_project

Solution scope:
solution_scope_fix

Fix all issues on document when saved at vscode:

autofix_on_save

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #3440 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3440      +/-   ##
==========================================
+ Coverage   85.93%   85.97%   +0.04%     
==========================================
  Files          60       60              
  Lines        1848     1854       +6     
  Branches      215      215              
==========================================
+ Hits         1588     1594       +6     
  Misses        200      200              
  Partials       60       60              
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 85.97% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/omnisharp/protocol.ts 79.13% <100.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3ecb3...3769538. Read the comment docs.

@JoeRobich
Copy link
Member

Updating OmniSharp to include the server-side changes in #3960

@JoeRobich
Copy link
Member

@savpek Is this ready to go in? GitHub checks didn't update. CI is passing https://travis-ci.org/github/OmniSharp/omnisharp-vscode/builds/716733951

@savpek
Copy link
Contributor Author

savpek commented Aug 11, 2020

@savpek Is this ready to go in? GitHub checks didn't update. CI is passing https://travis-ci.org/github/OmniSharp/omnisharp-vscode/builds/716733951

I think it is. It's quite a while when i wrote this but based on code it should do 🤔

@savpek savpek marked this pull request as ready for review August 11, 2020 07:43
@JoeRobich
Copy link
Member

The release of 3.1.401 SDK broke our CI. Fixed by specifying to install 3.1.302. Hopefully this run will pass and we'll merge

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich merged commit ba826dc into dotnet:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants