Make "Run/debug tests in context" position a link #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
approved these changes
Jul 17, 2020
JoeRobich
approved these changes
Jul 17, 2020
|
Thanks @RikkiGibson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the format for the context position so that it formats as a link in VS Code. This is handy when you are reviewing the test output logs and you want to get back to the context position for some tests that you ran previously.
This imitates the formatting for positions used when the compiler reports diagnostics and in stack traces at runtime.
Before:
src/Compilers/CSharp/Test/Symbol/Symbols/Source/NullablePublicAPITests.cs 3015:15After:
src/Compilers/CSharp/Test/Symbol/Symbols/Source/NullablePublicAPITests.cs(3015,15)You can actually try just including these strings in a terminal command and you will see that the former does not parse as a link but the latter does.
/cc @333fred @JoeRobich