-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Razor to 6.0.0-alpha.1.21201.19 #4470
Conversation
@@ -331,8 +331,7 @@ | |||
{ | |||
"id": "Razor", | |||
"description": "Razor Language Server (Windows / x64)", | |||
"url": "https://download.visualstudio.microsoft.com/download/pr/a1999a11-02b4-49cf-9716-bdf7fb656b0b/c2388ccf719057b1b8d29aab27173206/razorlanguageserver-win-x64-6.0.0-alpha.1.20575.5.zip", | |||
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-win-x64-6.0.0-alpha.1.20575.5.zip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separately working out where our own blob storage went. For now removing fallback url as it's not needed
@captainsafia with this I get spammed for Blazor debugging prompts. I assume not expected? |
@NTaylorMullen Nope, not expected. The code that displays that prompt lives in the omnisharp-vscode repo so it's unrelated to the insertion. Can you open an issue with more details and I'll take a look? I don't think this should block the insertion given where the codepath lies as mentioned above. |
- For this to work it requires the latest omnisharp-roslyn release. Fixes dotnet/aspnetcore#30834
3cd5ab0
to
2e29182
Compare
Codecov Report
@@ Coverage Diff @@
## master #4470 +/- ##
==========================================
- Coverage 69.00% 68.91% -0.10%
==========================================
Files 109 109
Lines 4282 4282
Branches 741 741
==========================================
- Hits 2955 2951 -4
- Misses 1123 1126 +3
- Partials 204 205 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Wasn't able to fullly try this out because it looks like O#'s "latest" release blob storage is down?
Fixes dotnet/aspnetcore#30834