-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AnalyzeOpenDocumentsOnly #5088
Add AnalyzeOpenDocumentsOnly #5088
Conversation
@neoGeneva Thanks for the contribution! Since an O# restart is required for this option to take effect, you can add the option name to the list in this file, so that users will be prompted to restart. https://github.com/OmniSharp/omnisharp-vscode/blob/090acf09c8bd9e6802e6c2566de87cbedbc07b5b/src/observers/OptionChangeObserver.ts#L15-L27 |
@JoeRobich Sweet, will do. It looks like |
Ah, good catch. Please do. |
…r `enableRoslynAnalyzers` changes.
Other than the typos, this is looking good. |
Sweet, thanks @333fred, all fixed. |
Woohoo, awesome! Thanks everybody 🙂 |
@neoGeneva Thanks for the contribution! I spun up a prerelease for anyone interested in trying it out https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.24.2-beta1 |
This pull request is exposing the new
AnalyzeOpenDocumentsOnly
feature merged into omnisharp-roslyn via OmniSharp/omnisharp-roslyn#2346This pull request does two main things:
fileOpen
andfileClose
endpointsAnalyzeOpenDocumentsOnly
flag as a startup parameterAnd one additional weird thing I should point out:
filesChanged
endpoint when an active editor changes. I found without this when switching between tabs the diagnostics would be out of date and I'd have to make a modification to force it to refresh the file, which was pretty anoying.