New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carlosguerravz/devcerts check #5589

Merged

CarlosGuerraVz merged 16 commits into master from carlosguerravz/devcerts_check

Feb 24, 2023

Collaborator

CarlosGuerraVz commented Feb 21, 2023 •

edited

Loading

This commit fixes #3187 by implementing the proposal in the comments.

Added launch option checkForDevCert and documented it on debugger-launchjson.md.
When debugging, if not on Linux, on remote, or on a browser, the extension runs dotnet dev-certs https --check to check for dev-certs.
If not found, it displays the following message:

Selecting yes will run dotnet dev-certs https --trust
More information will redirect to the page containing the description for the checkForDevCert` launch option.
If certificate creation fails it will log the failure to the C# output and will display a message offering to show the error output.
Tested on Windows and MacOS

CarlosGuerraVz added 3 commits

February 17, 2023 16:17


          added check for development certificates for debug. If not found the …

403e362

…user will be prompted to create them


          added succes and fail messages for self-signed certificate creation. …

2f7cb44

…also added a modal to the Don't ask again option for telling the user to ser checkForDevCert to false


          updated message

7f21e1b

CarlosGuerraVz requested review from WardenGnaw and gregg-miskelly

February 21, 2023 21:12

gregg-miskelly reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/utils/DotnetDevCertsHttps.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/utils/DotnetDevCertsHttps.ts Outdated Show resolved Hide resolved

CarlosGuerraVz added 2 commits

February 21, 2023 14:16


          changes message to have 'Yes' option as default, added comments, chan…

a4ee98a

…ged hasDotnetDevCertsHttps and createSelfSignedCert to not rely on the process string output and instead to just return false if the exec fails


          reordered again the options

f8a915c

gregg-miskelly reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/tools/OptionsSchema.json Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/utils/DotnetDevCertsHttps.ts Outdated Show resolved Hide resolved


          updated decription on options schema

c3cfb6b

gregg-miskelly reviewed

View reviewed changes

debugger-launchjson.md Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

debugger-launchjson.md Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

debugger-launchjson.md Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

CarlosGuerraVz added 2 commits

February 21, 2023 16:36


          updated optionsSchema.json and debugger-launchjson.md descriptions. U…

965bf57

…pdated functions to return error and exit code along strings. set not now option as iscloseaffordance


          updated description on debugger-launchjson.md

262aee8

WardenGnaw reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

CarlosGuerraVz added 4 commits

February 21, 2023 17:38


          changed option to More Information to redirect to the github md file

5c5b130


          moved check into a function to be able to re-ask if the user clicks o…

656ddf8

…n more info option


          added event for dev-dert creation failure

96b90ba


          typo

7c79d8e

WardenGnaw reviewed

View reviewed changes

src/utils/DotnetDevCertsHttps.ts Show resolved Hide resolved

WardenGnaw reviewed

View reviewed changes

src/utils/DotnetDevCertsHttps.ts Outdated Show resolved Hide resolved


          moved getDotNetExecutablePath() to getDotNetINfo.ts for better code r…

38c2b95

…euse

gregg-miskelly reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

src/coreclr-debug/debugConfigurationProvider.ts Show resolved Hide resolved

gregg-miskelly reviewed

View reviewed changes

Contributor

gregg-miskelly left a comment

Otherwise LGTM


          Added event ShowChannel to switch focus to C# output

110701c

CarlosGuerraVz commented

View reviewed changes

src/utils/DotnetDevCertsHttps.ts Outdated Show resolved Hide resolved

CarlosGuerraVz added 2 commits

February 23, 2023 12:59


          added check for exaact error code

532824b


          added status codes enum, and use dit to check specific return. dotnet…

084bbfc

… devcerts now also checks for trusted certificate

WardenGnaw approved these changes

View reviewed changes

CarlosGuerraVz merged commit ed84442 into master

CarlosGuerraVz deleted the carlosguerravz/devcerts_check branch

February 27, 2023 21:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet