New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underscore should be accepted for sub-domains #8

Open

vishalraj82 opened this issue May 8, 2018 · 1 comment

vishalraj82 commented May 8, 2018

Having underscore in sub-domain is a valid use case, but currently not supported by the library.
Please see - https://stackoverflow.com/questions/2180465/can-domain-name-subdomains-have-an-underscore-in-it

Contributor

paras20xx commented May 10, 2018

Need to verify and merge branch:
https://github.com/One-com/one-validation/tree/underscore-in-subdomains

@papandreou
Kindly have a look at:
b2050f3#comments

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment