Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sidecarBaseUrl #1280

Closed
aaronbrethorst opened this issue Nov 27, 2024 · 0 comments · Fixed by #1281
Closed

Add support for sidecarBaseUrl #1280

aaronbrethorst opened this issue Nov 27, 2024 · 0 comments · Fixed by #1281
Assignees
@amrhossamdev

Comments

@aaronbrethorst
Copy link
Member

Now that we have a new regions file published with the sidecarBaseUrl field, we can remove hardcoded references to "https://onebusaway.co" and use that value instead. When sidecarBaseUrl is null, we will know that alerts, surveys, and notifications are not supported for that region.

This feature has already been added to the iOS in these two commits:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amrhossamdev amrhossamdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: add sidecar base url OneBusAway/onebusaway-android
2 participants
@aaronbrethorst @amrhossamdev