Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has 2.7.0 been released by accident? #580

Closed
rwillett opened this issue Nov 10, 2019 · 2 comments
Closed

Has 2.7.0 been released by accident? #580

rwillett opened this issue Nov 10, 2019 · 2 comments

Comments

@rwillett
Copy link

rwillett commented Nov 10, 2019

Description:
Just downloaded the latest (and greatest) one-signal release and it came up flagged as 2.7.0 rather than 2.6.0. Can't see any release note with whats changed.

Environment
cordova plugins shows

onesignal-cordova-plugin 2.7.0 "OneSignal Push Notifications"

Steps to Reproduce Issue:

cordova plugin rm onesignal-cordova-plugin
Stuff removed as it's boring
cordova plugin add onesignal-cordova-plugin
More stuff removed as thats boring....
cordova plugins
onesignal-cordova-plugin 2.7.0 "OneSignal Push Notifications"

Should I really use this one?

@rwillett
Copy link
Author

rwillett commented Nov 11, 2019

I have also had problems compiling it with Xcode 11.2 (11B52).

As per normal with Apple, they appear to have changed things around and to get 2.7.0 to compile I had to add in WebKit.framework and CoreGraphics.framework to the OneSignal extension to get it to work. I also added these libraries to the main application but not sure whether I needed to or not.

I still can't get Rich Media working with this but that's a different problem .

@rgomezp
Copy link
Contributor

rgomezp commented Nov 13, 2019

Howdy,
We just hadn't drafted a release. But it was no accident. Thanks for the reminder. Check out the release notes here: https://github.com/OneSignal/OneSignal-Cordova-SDK/releases/tag/2.7.0

For the second issue, see OneSignal/OneSignal-iOS-SDK#430

@rgomezp rgomezp closed this as completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants