Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSNotificationPayload missing exposed parseWithApns method #506

Closed
AndreaVitale opened this issue Jul 23, 2019 · 1 comment · Fixed by #508
Closed

OSNotificationPayload missing exposed parseWithApns method #506

AndreaVitale opened this issue Jul 23, 2019 · 1 comment · Fixed by #508

Comments

@AndreaVitale
Copy link

Description:

I'm creating a new Titanium module because the previous one isn't mantained anymore.

Due to Titanium' iOS module lifecycle, when I have to process an opened notification after an app' cold boot, I need to translate what I get from launchOptions.UIApplicationLaunchOptionsRemoteNotificationKey in a OSNotificationPayload.

What I need is to invoke this method but it isn't exposed inside the OSNotificationPayload declaration.

I added +(instancetype)parseWithApns:(NSDictionary*)message; after this line and everything is working as expected.

Is there some reason why this cannot be done?

Environment:

I'm using OneSignal iOS SDK v2.10.0 installed via Carthage.

@rgomezp
Copy link
Contributor

rgomezp commented Aug 2, 2019

Howdy,
Thanks for your question. It's a valid request and can be easily done. Look for this in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants