Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support vrm1 in Magick for now #1029

Closed
fire opened this issue Jun 13, 2023 · 2 comments
Closed

Only support vrm1 in Magick for now #1029

fire opened this issue Jun 13, 2023 · 2 comments
Assignees
Labels

Comments

@fire
Copy link
Contributor

fire commented Jun 13, 2023

The issue is related to the bone rolls of vrm0 and vrm1 in three.vrm. The bones are defined to always roll to the top, but they are not behaving as expected.

The forward rotation (180 degrees) of vrm0 is fixed in vrm1.

Good Examples

  • Green is up in local space.
  • Image:

image

image

Bad Examples

  • Bad Example Bone rolls invalid

  • Image: Bad Example 3

  • Bad Example 4 (A-Pose)

  • Image: Bad Example 4 (A-Pose)

Related Links

Describe the solution you'd like

Existing Solutions

  1. Ensure animation is in FBX format as per the Glitch demo used in Magick.

Proposed Solutions

  1. Ignore forward fixing by only supporting vrm1.
  2. Restrict to vrm 1 and revert ultra's rotation on the top node fix.
@benbot
Copy link
Contributor

benbot commented Jun 15, 2023

#1047 Should unblock this

@fire
Copy link
Contributor Author

fire commented Jun 15, 2023

Completed.

@fire fire closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@fire @benbot and others