Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dotted border on buttons in Firefox #2408

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Remove dotted border on buttons in Firefox #2408

merged 1 commit into from
Jun 4, 2018

Conversation

DASPRiD
Copy link
Contributor

@DASPRiD DASPRiD commented Apr 29, 2018

This PR will remove the border which Firefox inserts on all focused buttons. The normal :focus { outline: 0; } does actually not do anything here.

@asialgearoid
Copy link
Contributor

asialgearoid commented May 16, 2018

Thanks for the PR, @DASPRiD, this is a good idea. I think it would be better to put it after the existing outline: 0 right here:

Could you change your code to put it there instead?

@DASPRiD
Copy link
Contributor Author

DASPRiD commented May 31, 2018

Sorry for the long wait, I've updated the code accordingly.

@asialgearoid asialgearoid merged commit 5637b46 into OnsenUI:master Jun 4, 2018
@asialgearoid
Copy link
Contributor

Great, thanks for the PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants