Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biggoron misleadingly says to come back after a few days when handing in Eyedrops #1956

Closed
ETR-BTF opened this issue Apr 13, 2023 · 6 comments · Fixed by #2180
Closed

Biggoron misleadingly says to come back after a few days when handing in Eyedrops #1956

ETR-BTF opened this issue Apr 13, 2023 · 6 comments · Fixed by #2180
Labels
Type: Enhancement New feature or request
Milestone

Comments

@ETR-BTF
Copy link

ETR-BTF commented Apr 13, 2023

It's misleading both because you do actually need the Claim Check to get that item (i.e. it's not given "for free"), and because the 3 day waiting period has been patched out. The best solution would probably be to have him say something along the lines of "Come back with the Claim Check for another item" because that also works if the trade quest items are not shuffled.

image

@r0bd0g
Copy link

r0bd0g commented Apr 13, 2023

The three-day waiting period being patched out is misleading trade quest shuffle or no.

(Setting to have that be an optional speedup when???)

@ETR-BTF ETR-BTF changed the title Biggoron misleadingly says to come back after a few days when handing in Eyedrops with trade quest shuffle Biggoron misleadingly says to come back after a few days when handing in Eyedrops Apr 14, 2023
@ETR-BTF
Copy link
Author

ETR-BTF commented Apr 14, 2023

Yeah I guess that part of the issue title was superfluous lol.

@fenhl fenhl added the Type: Enhancement New feature or request label May 10, 2023
@fenhl
Copy link
Collaborator

fenhl commented May 10, 2023

Should be an easy fix. Any suggestions on the worrrrrding?

@fenhl
Copy link
Collaborator

fenhl commented May 10, 2023

Maybe the best way to handle it would be to skip the claim check step entirely when it's not shuffled and instead just give the BGS check (but still replace eyedrops with it in the inventory). Then we can make the wording of this text box specific to shuffled claim check.

@ETR-BTF
Copy link
Author

ETR-BTF commented May 11, 2023

Should be an easy fix. Any suggestions on the worrrrrding?

"Brrrring me the Claim Check...
to rrreceive anotherrrrrr item..."

Or something like that lol. Swap "item" for "gift" if you think that word is misleading (because "item" is sometimes used in the community to denote things that aren't junk or keys)

@r0bd0g
Copy link

r0bd0g commented May 12, 2023

I don't know that the vanilla text needs updating here just b/c there's a lot of texts that don't make sense when items are all shuffled around. But this case is a little different, at least in the case of trade shuffle off, because we really did remove the 3-day wait. Except I mean he's not wrong? 0 is a number of days, and you can wait longer if you want. If you must insist on updating the text I would reword it to remove reference to waiting, but not care about whether the new text makes sense in the context of trade shuffle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants