Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

Decouple and Generalize Event System #131

Closed
TelloViz opened this issue Nov 26, 2019 · 1 comment · Fixed by #162
Closed

Decouple and Generalize Event System #131

TelloViz opened this issue Nov 26, 2019 · 1 comment · Fixed by #162
Assignees
@milkyroute
Labels
enhancement When the issue is proposing an enhancement
Milestone
For the 0.17

Comments

@TelloViz
Copy link
Contributor

There is some diamond inheritance in the Event system and it is just generally quite coupled. It would be beneficial to clean that up and get everything a little more generalized.

It is generally recommended to prefer composition over multiple inheritance.
diamond
@TelloViz
Copy link
Contributor Author

I think @ShadowApex and the fellas over at Tuxemon are onto a good thing with their event system

image

@milkyroute milkyroute self-assigned this Nov 27, 2019
@milkyroute milkyroute added this to the For the 0.17 milestone Nov 27, 2019
@milkyroute milkyroute pinned this issue Nov 27, 2019
@milkyroute milkyroute added the enhancement When the issue is proposing an enhancement label Nov 27, 2019
@milkyroute milkyroute removed their assignment Nov 27, 2019
@TelloViz TelloViz mentioned this issue Nov 27, 2019
Open
@milkyroute milkyroute mentioned this issue Feb 9, 2020
Merged
4 tasks
@milkyroute milkyroute self-assigned this Feb 9, 2020
@milkyroute milkyroute removed their assignment Mar 25, 2020
@milkyroute milkyroute self-assigned this Mar 26, 2020
@milkyroute milkyroute mentioned this issue Mar 31, 2020
Merged
@milkyroute milkyroute unpinned this issue May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@milkyroute milkyroute

Labels
enhancement When the issue is proposing an enhancement
Projects
None yet
Milestone
For the 0.17
Development

Successfully merging a pull request may close this issue.

New event system OpMonTeam/OpMon-Archive
2 participants
@TelloViz @milkyroute