Chore/did signed adam comment #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yehjxraymond
changed the base branch from
master
to
feat/didSignedDocumentImpl
yehjxraymond
added a commit
that referenced
this pull request
Oct 2, 2020
* chore: scaffold for new verifier & refactor verifiers * wip * feat: didSignedDocumentStatus * fix: remove data * chore: added tests * Chore/did signed adam comment (#116) * chore: added changes from Adam's comment * fix: remove signer block Co-authored-by: Raymond Yeh <ray@geek.sg> * fix: errors to return UNEXPECTED_ERROR instead of INVALID * feat: didIdentityProof (#120) * feat: didIdentityProof * chore: removed dns-did support in didIdentityProof * feat: dnsDidProof * chore: skipping issuers for dns did * chore: skipping test for issuers not using did in didIdentityProof * chore: throwing for v3 * fix: existing integration tests * chore: integration test for documents issued with DID * fix: comments to fix dnsproof * fix: rm TODO list * fix: lint * fix: comments Co-authored-by: Raymond Yeh <ray@geek.sg> * feat: node cache for did resolution * fix: rm commitlint * feat: npm audit fix * feat: using getDnsDidRecords from dnsprove dep * feat: default verifier without top level DID * feat: updated to latest OA supporting DID signing (#124) Co-authored-by: Raymond Yeh <ray@geek.sg> * fix: rm cloudflare test * fix: undo temp fix for dnsprove * fix: types for signed document * fix: using isSignedWrappedV2Document * fix: typed reasons and removed any * feat: better error message coding Co-authored-by: Raymond Yeh <ray@geek.sg> BREAKING CHANGE: Removal of previous implementation of signed document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
idto top level property in theissuers. This corresponds to how w3c vc is working now.keyblock, leaving only the key id which is now the top level forkey.