Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stricter document store #133

Merged
merged 1 commit into from
Oct 30, 2020
Merged

feat: stricter document store #133

merged 1 commit into from
Oct 30, 2020

Conversation

yehjxraymond
Copy link
Contributor

@yehjxraymond yehjxraymond commented Oct 30, 2020 •
edited
Loading

Stricter check for document store verifier

  • Throws error when not all issuers are using document store
  • Refactored to use withCodedErrorHandler to handle any error in the verifier
  • Changed logic for error handling when querying smart contract, when we can determine that a document is not issued or revoked, we return false for issued or true for revoked (no error here). Only when it's an unknown error or server error, we allow it to bubble up as error (and issued & revoked will not be set)
  • Simplified reason within the data object, we already know it is not issued or is revoked at that point in time. reason at the root fragment is unaffected.

@yehjxraymond yehjxraymond changed the base branch from master to feat/stricterVerification October 30, 2020 08:39
@yehjxraymond yehjxraymond merged commit c5fa8a7 into feat/stricterVerification Oct 30, 2020
@yehjxraymond yehjxraymond deleted the feat/stricterDocumentStore branch October 30, 2020 08:49
yehjxraymond added a commit that referenced this pull request Nov 6, 2020
@yehjxraymond
feat: stricter verification (#132)
fcbe8f9 
* feat: restrict token registry to fail on multiple issuers (#129)

* feat: restrict token registry to fail on multiple issuers

* feat: added reasons back

* feat: added server error

* feat: stricter document store verifier (#133)

* feat: stricter did signed document verifier (#134)

* feat: stricter did identity (#135)

* chore: refactored error handling

* feat: restricted didIdentityProof

* feat: stricter dns did identity (#136)

* feat: restricted dnsDid

* feat: stricter dnsTxt (#137)

* feat: aligning data.reason in individual fragments (#138)

* feat: aligning naming convention with files and modules (#139)

BREAKING CHANGE: Modules name changes and stricter verification rules
@john-dot-oa john-dot-oa mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yehjxraymond