feat: oav3 document store #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nebulis
reviewed
Jan 25, 2021
| @@ -24,10 +27,11 @@ const ethereumDocumentConfig = { | |||
| address: "0x1245e5B64D785b25057f7438F715f4aA5D965733", | |||
| key: "0x416f14debf10172f04bef09f9b774480561ee3f05ee1a6f75df3c71ec0c60666", | |||
| }, | |||
| timeout: 60 * 1000, // 1 min timeout for contract to execute | |||
| timeout: 5 * 60 * 1000, // 5 min timeout for contract to execute | |||
There was a problem hiding this comment.
Its enough for now, but have seen cases where the network choked
Nebulis
reviewed
Jan 25, 2021
| @@ -2,13 +2,16 @@ | |||
| import { __unsafe__use__it__at__your__own__risks__wrapDocument, v3 } from "@govtechsg/open-attestation"; | |||
There was a problem hiding this comment.
do we need to commit the generated files ?
There was a problem hiding this comment.
yes pls, it takes a while to generate all of them, its just to generate test fixtures infrequently...
Nebulis
reviewed
Jan 25, 2021
| status: "SKIPPED", | ||
| type, | ||
|
|
||
| const test: VerifierType["test"] = (document) => { |
There was a problem hiding this comment.
just to add that isWrappedV3Document is not correct as well (it doesn't do what you expect). We might need to discuss if we actually want to have such a helper in our lib :)
Nebulis
approved these changes
Jan 25, 2021
yehjxraymond
added a commit
that referenced
this pull request
Feb 9, 2021
* chore: deleted previous v3 * feat: test fixture generation for dnsdid and did * fix: broken test * feat: documentIntegrity/hash working for v3 (#151) Co-authored-by: Raymond Yeh <ray@geek.sg> * feat: documentStatus/didSigned for v3 * fix: broken test * fix: lint & tests * fix: npm audit * chore: auto issue on generate script * feat: oav3 document store (#152) * chore: refactored verifier into skip, test & verify * feat: document store verification & generating revoked docs * chore: update comment Co-authored-by: Raymond Yeh <ray@geek.sg> * feat: verification for v3 with did identity proof (#154) Co-authored-by: Raymond Yeh <ray@geek.sg> * feat: oav3 dns did (#155) * feat: verification for dns-did * chore: refactored constraint checks * fix: lint * fix: test description Co-authored-by: Nebulis <nebounet@gmail.com> Co-authored-by: Raymond Yeh <ray@geek.sg> Co-authored-by: Nebulis <nebounet@gmail.com> * [WIP] feat: oav3 token registry (#153) * chore: refactored into test verify skip * chore: refactoring test [wip] * chore: refractor test * chores: empty-test-for-v3 * chore: removed unnecessary tests * chore: refractor-test-case * chore: added-v3-test * chore: added-v3-verify * test: added v3-verify-test * chore: fix-lint * chore: refactored code Co-authored-by: Raymond Yeh <ray@geek.sg> Co-authored-by: Chen Ren <siachenren@gmail.com> * feat: v3 dns txt (#156) * chore: refactored previous verifier * chore: refactored test * chore: rename test & added v3 tests * feat: verify for v3 documents * fix: lint * fix: token registry's test & oav3 integration test (#157) * chore: integration test for all OAv3 documents * chore: better var naming * fix: lint * chore: added getFailingFragments to tests * fix: reasons for dnsTxt moved out Co-authored-by: Raymond Yeh <ray@geek.sg> Co-authored-by: Raymond Yeh <ray@geek.sg> * chore: reference to generate script in readme * chore: using did-sign for v3 signing * chore: deleted unused code path * fix: better error message when document dont match * fix: uncommented document generation step Co-authored-by: Raymond Yeh <ray@geek.sg> Co-authored-by: Nebulis <nebounet@gmail.com> Co-authored-by: Chen Ren <siachenren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.