Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exports path #289

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix: exports path #289

merged 1 commit into from
Jun 14, 2024

Conversation

HJunyuan
Copy link
Member

Summary

End-users are not able to import the oa-verify library successfully:

  • type: "commonjs" was conflicting with instruction to export as module causing end-users will face this error:
    Module parse failed: 'import' and 'export' may appear only with 'sourceType: module'
    
  • Typo on exports.default path

Changes

  • Remove type and source
  • Fix exports.default file path (was missing m previously)
  • Add exports.import and exports.types file path
{
  // ...
  "exports": {
    "require": "./dist/index.js",
    "import": "./dist/index.modern.mjs",
    "default": "./dist/index.modern.mjs",
    "types": "./dist/types/index.d.ts"
  },
  // ...
}

@HJunyuan HJunyuan merged commit f72bd51 into master Jun 14, 2024
6 checks passed
@HJunyuan HJunyuan deleted the fix/export-path branch June 14, 2024 05:45
Copy link
Contributor

🎉 This PR is included in version 9.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

🎉 This PR is included in version 9.3.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants