Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dns verifier #77

Merged
merged 4 commits into from
Jan 8, 2020
Merged

fix: dns verifier #77

merged 4 commits into from
Jan 8, 2020

Conversation

Nebulis
Copy link
Contributor

@Nebulis Nebulis commented Dec 31, 2019 •
edited
Loading

  • only verify if the issuer is using DNS-TXT (dont throw error if he's not)
  • added resolution status for every issuer, even if it has been skipped for one person
  • forward the resolution status in the data object

rjchow
rjchow reviewed Jan 2, 2020
View reviewed changes
src/verifiers/openAttestationDnsTxt.ts Show resolved Hide resolved
src/verifiers/openAttestationDnsTxt.ts Outdated
if (invalidIdentity !== -1) {
const value =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put more effort into naming your variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to smartContractAddress

src/verifiers/openAttestationDnsTxt.ts Outdated Show resolved Hide resolved
src/verifiers/openAttestationDnsTxt.ts Show resolved Hide resolved
src/verifiers/openAttestationDnsTxt.v2.test.ts Show resolved Hide resolved
@Nebulis Nebulis mentioned this pull request Jan 2, 2020
Open
@Nebulis Nebulis merged commit e1e040d into master Jan 8, 2020
@john-dot-oa
Copy link
Contributor

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjchow rjchow rjchow approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nebulis @john-dot-oa @rjchow