feat: 🎸 verify signed proof blocks #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nebulis
reviewed
Apr 27, 2020
src/verifiers/documentStoreIssued/openAttestationDocumentStoreIssued.ts
Outdated
Show resolved
Hide resolved
Nebulis
reviewed
Apr 27, 2020
Nebulis
reviewed
Apr 27, 2020
test/fixtures/v2/documentRopstenInvalidWithDIDSignedProofBlockProperHash.ts
Outdated
Show resolved
Hide resolved
Nebulis
reviewed
Apr 27, 2020
test/fixtures/v2/documentRopstenValidWithDIDSignedProofBlockProperHash.ts
Outdated
Show resolved
Hide resolved
Nebulis
reviewed
Apr 27, 2020
Nebulis
reviewed
Apr 27, 2020
Nebulis
reviewed
Apr 27, 2020
Nebulis
reviewed
Apr 27, 2020
Nebulis
reviewed
Apr 27, 2020
Nebulis
reviewed
May 3, 2020
Nebulis
reviewed
May 3, 2020
Nebulis
reviewed
May 4, 2020
test/fixtures/v2/documentMainnetValidWithDIDSignedProofBlockProperHash.ts
Outdated
Show resolved
Hide resolved
Nebulis
reviewed
May 4, 2020
Nebulis
reviewed
May 4, 2020
test/fixtures/v2/documentRopstenInvalidWithDIDSignedProofBlockProperHash.ts
Outdated
Show resolved
Hide resolved
Nebulis
reviewed
May 4, 2020
test/fixtures/v2/documentRopstenInvalidWithDIDSignedProofBlockProperHash.ts
Outdated
Show resolved
Hide resolved
Nebulis
reviewed
May 4, 2020
test/fixtures/v2/documentRopstenValidWithDIDSignedProofBlock.ts
Outdated
Show resolved
Hide resolved
Nebulis
reviewed
May 4, 2020
test/fixtures/v2/documentRopstenValidWithDIDSignedProofBlock.ts
Outdated
Show resolved
Hide resolved
Nebulis
reviewed
May 4, 2020
Nebulis
reviewed
May 6, 2020
Nebulis
approved these changes
May 6, 2020
Nebulis
approved these changes
May 6, 2020
Allow the documents to be signed diretly and a proof block appended. Extend the verifier to use this proof block if it exists to verify the status of the document instead of querying the Ethereum based document store.
Update the w3c-did verifier to no longer accept DIDs as the proof verification method. Instead just accept public keys directly. Also split out the w3c verifier to be an independent verifier.
Also remove axios as unused now and lint.
Update fixture names to be accurate of the signed proof blocks. 1 valid, 1 with invalid type and 1 with invalid signature. Comments added in each invalid to highlight why. Tests updated to build and use verifier.
Nebulis
force-pushed
the
feat/AL-add-signed-proof
branch
from
a72b72a to
4bd29bb
Compare
Nebulis
changed the title
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the documents to be signed diretly and a proof block appended. Extend the verifier to use this proof block if it exists to verify if the document has been issued instead of querying the Ethereum based document store. Allows real-time issuance with no dependence on the blockchain
(transaction inclusion) and thus no associated tx costs either. We also have a reference implementation for the signature generation and appending the proof we could share.