Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_url with GeoJSON: alignation with load_geojson #450

Open
soxofaan opened this issue Aug 3, 2023 · 1 comment
Open

load_url with GeoJSON: alignation with load_geojson #450

soxofaan opened this issue Aug 3, 2023 · 1 comment

Comments

@soxofaan
Copy link
Member

soxofaan commented Aug 3, 2023

This is follow-up of multiple earlier discussions (e.g. #322 #415 #427 #346).

Current openeo-processes draft has:

  • load_geojson to load inline GeoJSON object, supports a properties parameter to let user select feature properties to load as cube data
  • load_url to (among others) load GeoJSON from a URL, supports a generic options parameter

The properties parameter of load_geojson is not that trivial (e.g. see #448), but it is quite an important feature.

How to get this feature in load_url+GeoJSON?
I guess currently the only way is that the "GeoJSON" input format (GET /file_formats) defines a properties parameter that aligns with the properties parameter of load_geojson.

This has a couple of disadvantages for users, backends and documentation:

  • duplication between a process spec and a file format option.
  • For load_url+GeoJSON it's a lot harder for regular users to discover the properties feature and it's documentation.
  • Also for clients environments (e.g. Python client) it's a lot harder to suggest the properties option for the load_url process, while this is trivial for load_geojson

Possible alternative: add support in load_geojson for loading from URL in addition to inline GeoJSON. I would guess that the additional implementation work for a back-end implementer is very minimal to add this.

This has been discussed before, but I can not completely reconstruct if this idea was intentionally dropped or forgotten.

@SerRichard
Copy link

This would also be good for the openeo-processes-dask. Currently we're using a custom "load_vector_cube" process for loading the remote geometries and it would be better to replace it with the load_geojson process in the implementations ( for the obvious benefit of alignment ).

In order to realise this change we would currently need to support the additional process of load_url in the dask processes, but, as already mentioned the code to support loading from URLs direclty in the geojson implementation is minimal, and would be less work than implementing load_url and ensuring correct behaviour on our side.

Whenever the discussion is held, also a thumbs up from eodc for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants