Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated usage of setup.py #2336

Closed
matrss opened this issue Apr 25, 2024 · 7 comments
Closed

Remove deprecated usage of setup.py #2336

matrss opened this issue Apr 25, 2024 · 7 comments
Labels
packaging upstream fix needed a dependency of us needs an improvement
Milestone

Comments

@matrss
Copy link
Collaborator

matrss commented Apr 25, 2024

However, python setup.py and the use of setup.py as a command line tool are deprecated.

This means that commands such as the following MUST NOT be run anymore:

  • python setup.py install

  • python setup.py develop

  • python setup.py sdist

  • python setup.py bdist_wheel

https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

We have this kind of usage here:

%PYTHON% setup.py install --single-version-externally-managed --record record.txt

@matrss matrss added this to the 8.3.5 milestone Apr 25, 2024
@ReimarBauer
Copy link
Member

ReimarBauer commented Apr 25, 2024

But it has also a site effect for us on
https://docs.conda.io/projects/conda-build/en/stable/user-guide/tutorials/build-pkgs.html#writing-the-build-script-files-build-sh-and-bld-bat

We maybe have to pin setuptools for 8.3.5

@ReimarBauer ReimarBauer modified the milestones: 8.3.5, 9.0.0 Apr 25, 2024
@ReimarBauer
Copy link
Member

conda/conda-build#5311

@ReimarBauer ReimarBauer added the upstream fix needed a dependency of us needs an improvement label Apr 25, 2024
@ReimarBauer
Copy link
Member

We recheck this short for the release.

@ReimarBauer
Copy link
Member

conda/menuinst#202

@ReimarBauer ReimarBauer modified the milestones: 8.3.5, 9.0.0 May 8, 2024
@ReimarBauer
Copy link
Member

I shift this to the next major because that needs some effort on conda-build to track that down.

@ReimarBauer
Copy link
Member

When this is fixed we can remove it
conda/conda-build#5311

@ReimarBauer ReimarBauer modified the milestones: 9.0.0, 10.0.0 May 16, 2024
@matrss
Copy link
Collaborator Author

matrss commented Feb 21, 2025

This is fixed by #2298 because we no longer have the localbuild directory at all.

@matrss matrss closed this as completed Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging upstream fix needed a dependency of us needs an improvement
Projects
None yet
Development

No branches or pull requests

2 participants