Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the PR template #2472

Open
matrss opened this issue Aug 19, 2024 · 0 comments
Open

Revise the PR template #2472

matrss opened this issue Aug 19, 2024 · 0 comments

Comments

@matrss
Copy link
Collaborator

matrss commented Aug 19, 2024

Noone is actually fully adhering to what the PR template asks of PRs. It asks twice for the associated issue and if the PR is a breaking change, and suggests a naming scheme that doesn't reflect the lived reality.

I think it can be condensed to something much shorter, and if we really want to follow conventional commits for PR titles, as the template suggests, we should make that a criteria for code review. Or just drop it from the template if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant