Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the flask-native global configuration store instead of rolling our own #2506

Open
matrss opened this issue Sep 3, 2024 · 1 comment
Open

Comments

@matrss
Copy link
Collaborator

matrss commented Sep 3, 2024

Every Flask app has a .config attribute to store configuration. Additionally, for MSColab we have mscolab_settings. I think this is redundant, we could just use app.config for everything that should be made globally available in the application in a key-value fashion.

This would also become important once there is not just a singular global APP instance, but the possibility to instantiate more then one Flask app, as each app needs its own configuration. This is something that mscolab_settings is not set up for ATM.

This came up in #2499 (comment).

@ReimarBauer
Copy link
Member

we used mostly the same pattern as for mswms_settings. Also there we maybe can move the server configurations to the app.config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants