feat:command changes #2644
Open
feat:command changes #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReimarBauer
requested changes
Feb 13, 2025
| @@ -44,6 +44,8 @@ def main(): | |||
| parser.add_argument("--debug", help="show debugging log messages on console", action="store_true", default=False) | |||
| parser.add_argument("--logfile", help="If set to a name log output goes to that file", dest="logfile", | |||
| default=None) | |||
| parser.add_argument("-s", "--seed", help="creates demodata for the mswms server", | |||
| action="store_true", default=False) | |||
There was a problem hiding this comment.
and what does this?
Have you tried the examples?
There was a problem hiding this comment.
and what does this?
Have you tried the examples?
It adds an argument '-s' or '--seed' to enable data seeding using the mswms command.
There was a problem hiding this comment.
and how is the method called?
Does it create demodata in a dir as the description says?
There was a problem hiding this comment.
no it is not creating
There was a problem hiding this comment.
can u give some hint where to do the changes?
There was a problem hiding this comment.
look in conftest for an example, this creates also demodata for the tests.
|
@anj20 do you have time to finish this in the next days? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?: Replace the mswms_demodata command with a --seed option for the mswms command, aligning it with the behavior of the seed option in mscolab
Fixes #2631
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Verified that the seed function runs correctly when executed using mswms -seed
Checklist:
<type>: <subject>