Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more colors added for the zenith angle #2642

Closed
wants to merge 2 commits into from

Conversation

ReimarBauer
Copy link
Member

Purpose of PR?:

Fixes #2638

suggested by @joernu76

@ReimarBauer ReimarBauer requested a review from joernu76 February 11, 2025 19:16
@ReimarBauer ReimarBauer linked an issue Feb 11, 2025 that may be closed by this pull request
@ReimarBauer
Copy link
Member Author

that´s an color example
Bildschirmfoto 2025-02-11 um 20 25 39

@ReimarBauer ReimarBauer requested a review from jgrooss February 11, 2025 19:39
@jgrooss
Copy link
Contributor

jgrooss commented Feb 12, 2025

I don't see the difference.
topview_sza_new
topview_sza_old

I should be clearer in what was requested by the remote sensing (DOAS) group: Klaus writes:
"...wäre die Frage ob man auch mehr Bereiche definieren kann, also z.B. immer von erste Zahl bis zur zweiten Zahl von 80, 81, 82, 83, 84, 85, 86, 87.0, 87.5, 88.0, 88.5, 90.0, 90.5, 91.0, 91.5, 92.0, also in Summe 15 Bereiche, die man auf Regenbogenfarben abbilden müsste."

I would also propose to change the wording from "altitude" to "zenith"

@ReimarBauer
Copy link
Member Author

ReimarBauer commented Feb 12, 2025

 should be clearer in what was requested by the remote sensing (DOAS) group: Klaus writes:
"...wäre die Frage ob man auch mehr Bereiche definieren kann, also z.B. immer von erste Zahl bis zur zweiten Zahl von 80, 81, 82, 83, 84, 85, 86, 87.0, 87.5, 88.0, 88.5, 90.0, 90.5, 91.0, 91.5, 92.0, also in Summe 15 Bereiche, die man auf Regenbogenfarben abbilden müsste."

I would also propose to change the wording from "altitude" to "zenith"

What is your takeoff time and the destination time of your 2nd point?
altitude ?

The range is not something I want to add in this minor change. This is then something Joern can lookup. Likly the UI for the docking widget needs more options.

For a takeoff at 10:34 to destination at 13:25 it looks for me like:
gradient

@jgrooss
Copy link
Contributor

jgrooss commented Feb 12, 2025

The times were given in the table view. In my case it was 2023-08-06 09:00 and 12:31 UTC

@ReimarBauer
Copy link
Member Author

That can´t be easily done in a patch level or minor in the next hours, so we save it as as task for later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add solar zenith angle to top view/Remote sensing
2 participants